Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gps_rescue_min_start_dist #3076

Merged
merged 1 commit into from Nov 13, 2022
Merged

Fix gps_rescue_min_start_dist #3076

merged 1 commit into from Nov 13, 2022

Conversation

haslinghuis
Copy link
Member

Sets gps_rescue_min_start_dist range to start at 20 in UI.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Nov 9, 2022
@haslinghuis haslinghuis self-assigned this Nov 9, 2022
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 9, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

KarateBrot
KarateBrot previously approved these changes Nov 9, 2022
View reviewed changes
sugaarK
sugaarK previously approved these changes Nov 10, 2022
View reviewed changes
McGiverGim
McGiverGim requested changes Nov 10, 2022
View reviewed changes
src/tabs/failsafe.html Outdated Show resolved Hide resolved
@haslinghuis haslinghuis dismissed stale reviews from sugaarK and KarateBrot via 1bb17ee November 10, 2022 12:02
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 907d5b0 into betaflight:master Nov 13, 2022
Finalizing Firmware 4.4 Release automation moved this from Review to Closed Nov 13, 2022
@haslinghuis haslinghuis deleted the fix-gps_rescue_min_start_dist branch November 13, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@sugaarK sugaarK sugaarK left review comments

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: BUGFIX
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@haslinghuis @blckmn @McGiverGim @ctzsnooze @KarateBrot @sugaarK