Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: Updating some messaging labels. #3139

Merged
merged 1 commit into from Dec 13, 2022
Merged

Housekeeping: Updating some messaging labels. #3139

merged 1 commit into from Dec 13, 2022

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Dec 12, 2022

No description provided.

@blckmn blckmn self-assigned this Dec 12, 2022
@blckmn blckmn added this to the 10.9.0 milestone Dec 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member Author

blckmn commented Dec 13, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
We must try to have this kind of PRs with fixes to the messages file, before any RC. This PR produces that the translations for this phrases are removed in Crowdin, and the translators must translate them again. Some of them will do, but others not, so better to merge them soon to give time to the translators.

@haslinghuis haslinghuis merged commit f0cdf83 into betaflight:master Dec 13, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 13, 2022
@blckmn blckmn deleted the labelupdate branch December 16, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@blckmn blckmn

Labels
Cleanup Housekeeping RN: IMPROVEMENT
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blckmn @McGiverGim @haslinghuis