Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Load firmware online button not enabled if not in expert mode #3142

Merged
merged 1 commit into from Dec 14, 2022

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Dec 14, 2022

As per the label on the tin.

If the expert mode was not enabled, and the cloud build was true, then the load firmware online would not be enabled.

A work around is to select a non-cloud build firmware option, and then reselect the cloud build firmware. This is not ideal for users - so this is considered an urgent fix.

@blckmn blckmn added this to the 10.9.0 milestone Dec 14, 2022
@blckmn blckmn self-assigned this Dec 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member Author

blckmn commented Dec 14, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 54747c9 into betaflight:master Dec 14, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 14, 2022
@blckmn blckmn deleted the release_selection branch December 16, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants