Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT: As per suggestion, one RX protocol, and one Telem protocol #3161

Merged
merged 1 commit into from Dec 26, 2022

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Dec 24, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@McGiverGim
Copy link
Member

Why only one? I suppose the 99% of people will have enough with one, but what is the reason to limit this?

@blckmn
Copy link
Member Author

blckmn commented Dec 24, 2022

Why only one? I suppose the 99% of people will have enough with one, but what is the reason to limit this?

I am not a fan of restricting it to one personally. It has been suggested to only allow one, but I have added the for discussion label, as I think it should be discussed first (before we commit to it).

@blckmn
Copy link
Member Author

blckmn commented Dec 24, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@McGiverGim
Copy link
Member

@blckmn can the users, if they want, use the "custom defines" to define more than one RX protocol, as a workaround for the user who needs more than one? If they can, then this PR is ok to me.

@blckmn
Copy link
Member Author

blckmn commented Dec 24, 2022

user

Yes they will be able to do that.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 24, 2022
@blckmn blckmn merged commit 072be2e into betaflight:master Dec 26, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 26, 2022
@blckmn blckmn deleted the single_option branch December 26, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants