Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings display #3174

Merged
merged 1 commit into from Dec 27, 2022
Merged

Fix warnings display #3174

merged 1 commit into from Dec 27, 2022

Conversation

haslinghuis
Copy link
Member

Fixes: #3168

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 27, 2022
@haslinghuis haslinghuis self-assigned this Dec 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 27, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@chakflying
Copy link

Looks good to me. Thanks for the quick fix.

@haslinghuis haslinghuis merged commit d3391ff into betaflight:master Dec 27, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 27, 2022
@haslinghuis haslinghuis deleted the fix-pid-warning branch December 27, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

PID Slider warning not updated to account for the PID Profile name field
4 participants
@haslinghuis @blckmn @chakflying @McGiverGim