Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language sort optionlist at LED tab #3178

Merged
merged 2 commits into from Dec 30, 2022
Merged

Language sort optionlist at LED tab #3178

merged 2 commits into from Dec 30, 2022

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Dec 29, 2022

Sort 2 optionlist using sortSelect -> Language sort

@HThuren HThuren changed the title Sort optionlist at LED tab Language sort optionlist at LED tab Dec 29, 2022
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 29, 2022
@blckmn
Copy link
Member

blckmn commented Dec 29, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@HThuren
Update led_strip.js
bbcd8a4 
Do the suggestion to code
(and remove some blank lines)
@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member Author

HThuren commented Dec 30, 2022

Thank you

@haslinghuis haslinghuis merged commit ff5913b into betaflight:master Dec 30, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 30, 2022
@HThuren HThuren deleted the SortLEDselects branch December 30, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim left review comments

@haslinghuis haslinghuis haslinghuis approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HThuren @blckmn @McGiverGim @haslinghuis @sugaarK