Fix local download of hex file #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McGiverGim
force-pushed
the
fix_save_hex
branch
from
c2f7f85
to
cdc7c15
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
|
AUTOMERGE: (FAIL)
|
haslinghuis
approved these changes
Dec 29, 2022
sugaarK
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users clicks on the progress bar, in the name of the hex file, the Configurator must show a save file dialog to store the file in local.
Now, it does nothing because the JQuery attach command is being executed before the DOM for the file link is created. This PR fixes it.
It adds too the file name to the summary variable, that it seems was lost at some refactoring. I don't know if this is the best place to put it but it works.