Refactor config storage to use modules #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmelevskij
force-pushed
the
chore/config-storage-modules
branch
3 times, most recently
from
411e6e9
to
c1d3fee
Compare
chmelevskij
force-pushed
the
chore/config-storage-modules
branch
from
c1d3fee
to
94d41ff
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
haslinghuis
approved these changes
Dec 31, 2022
|
AUTOMERGE: (FAIL)
|
blckmn
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use esm module to handle interaction with config storage.
This PR replaces all the usages in code which is module based. There are few parts of the system which are not yet esm so those parts are still using old global scope approach.