Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flasher tab: fix wiki button #3198

Merged
merged 1 commit into from Jan 5, 2023

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Jan 1, 2023

Fixes the wiki button on flasher tab. Bug pointed by @haslinghuis

For the future: I think that the wiki button needs a change. Either remove it from everywhere or make it more meaningful.
Now it just points to the same wiki page.

Also, the "Firmware Flasher" header is not necessary in my opinion.... maybe :)

@github-actions

This comment has been minimized.

@haslinghuis
Copy link
Member

In future each tab should point to it's own wiki page.

Only added the header as it's used on all other tabs. The whole page needs a redesign anyway using a step by step procedure which also would preset / lock other settings.

@limonspb
Copy link
Member Author

limonspb commented Jan 1, 2023

In future each tab should point to it's own wiki page.

Only added the header as it's used on all other tabs. The whole page needs a redesign anyway using a step by step procedure which also would preset / lock other settings.

all these tabs don't have headers actually:
image

@blckmn
Copy link
Member

blckmn commented Jan 1, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

We only need the wiki button.

src/js/gui.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 6d08e45 into betaflight:master Jan 5, 2023
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Jan 5, 2023
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants