Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Android APK missing from RC3 #3205

Merged
merged 1 commit into from Jan 5, 2023
Merged

FIX: Android APK missing from RC3 #3205

merged 1 commit into from Jan 5, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 4, 2023

No description provided.

@blckmn blckmn added this to the 10.9.0 milestone Jan 4, 2023
@blckmn blckmn self-assigned this Jan 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member Author

blckmn commented Jan 4, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@McGiverGim
Copy link
Member

This is not the good solution. For Android the idea was generate the release apk with a private certificate and publish it at Play Store.
We are finally releasing the Android version with a public certificate?

@blckmn
Copy link
Member Author

blckmn commented Jan 4, 2023

This is not the good solution. For Android the idea was generate the release apk with a private certificate and publish it at Play Store. We are finally releasing the Android version with a public certificate?

This is restoring functionality to where it was before. I am looking at getting the playstore certificate setup also.

@blckmn blckmn merged commit 0a8701a into betaflight:master Jan 5, 2023
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Jan 5, 2023
@blckmn blckmn deleted the fix_android branch January 5, 2023 00:19
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Jan 5, 2023
@blckmn @chmelevskij
FIX: Android APK missing from RC3 (betaflight#3205)
719e49f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@blckmn blckmn

Labels
Android fixes broken build RN: BUGFIX
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blckmn @McGiverGim @haslinghuis