Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dynamic notch warning #3253

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Enable dynamic notch warning #3253

merged 1 commit into from
Jan 17, 2023

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jan 16, 2023
@haslinghuis haslinghuis self-assigned this Jan 16, 2023
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis marked this pull request as draft January 16, 2023 19:18
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis marked this pull request as ready for review January 16, 2023 20:26
@blckmn
Copy link
Member

blckmn commented Jan 16, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

KarateBrot
KarateBrot requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@KarateBrot KarateBrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a suggestion to give it a shorter name

locales/en/messages.json Outdated Show resolved Hide resolved
src/tabs/pid_tuning.html Outdated Show resolved Hide resolved
@haslinghuis
Copy link
Member Author

image

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member Author

After using a preset and arriving on the page we should adjust the message.
Otherwise we should enforce in firmware itself.

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis
Copy link
Member Author

We are using tables in this tab for presentation. Tried margin but not getting expected results. Already spent too much time on presentation as we need to migrate to templates.

image

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@KarateBrot
Copy link
Member

We are using tables in this tab for presentation. Tried margin but not getting expected results. Already spent too much time on presentation as we need to migrate to templates.

Looks pretty good anyway! 👌

@haslinghuis haslinghuis merged commit 51ed2dd into betaflight:master Jan 17, 2023
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Jan 17, 2023
@haslinghuis haslinghuis deleted the fix-pidloop-warning branch January 17, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @blckmn @KarateBrot @McGiverGim