Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ExpressLRS "passphrase" to "binding phrase" #3257

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

rickard-von-essen
Copy link
Contributor

@rickard-von-essen rickard-von-essen commented Jan 17, 2023

Rename ExpressLRS passphrase to binding phrase to be coherent with ExpressLRS Configurator and documentation.

Note: this probably puts the translations a bit off since the most likely translated passphrase, for example the French (fr) translation reads "Phrase secrète".

Closes #3255

This make Betaflight Configurator coherent with ExpressLRS naming.

Closes betaflight#3255
@rickard-von-essen
Copy link
Contributor Author

I did not squash these two commits since I wanted to give the option of only picking 6fcfd0e.

@haslinghuis
Copy link
Member

You only have to change the english label. Other languages are updated automatically using crowdin.

@blckmn
Copy link
Member

blckmn commented Jan 17, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit 80686eb into betaflight:master Jan 23, 2023
@haslinghuis haslinghuis modified the milestones: 10.10.0, 10.9.0 Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Rename ExpressLRS "passphrase" to "binding phrase"
5 participants