Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified configurator version checking #3346

Merged
merged 1 commit into from Feb 18, 2023
Merged

Simplified configurator version checking #3346

merged 1 commit into from Feb 18, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 18, 2023

As we now have the build API we can perform the version checking server side, and calculate if there is a new version available.

If there is no contact with the build API then the configurator will simply continue to load.

@blckmn blckmn self-assigned this Feb 18, 2023
@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 18, 2023
@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member Author

blckmn commented Feb 18, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

chmelevskij
chmelevskij approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@chmelevskij chmelevskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand this correctly. It's just to check what's the latest live release right?

@haslinghuis haslinghuis merged commit 6618378 into betaflight:master Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@blckmn blckmn

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blckmn @chmelevskij @haslinghuis