Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware info on setup tab #3369

Merged
merged 11 commits into from Mar 16, 2023
Merged

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Mar 5, 2023

After, with possibility to future additions of info from MCU in system info.
Now MSP API version, Build date and Build options for firmware build.
image

Before
image

@github-actions

This comment has been minimized.

@haslinghuis
Copy link
Member

We also could expose build key and build options

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 5, 2023
@HThuren
Copy link
Member Author

HThuren commented Mar 5, 2023

We also could expose build key and build options

Yes, but they seems to be empty (or are this becourse I use own build)

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Mar 5, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

MSP2_GET_TEXT

See also https://github.com/betaflight/betaflight-configurator/pull/3332

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@HThuren HThuren changed the title More info on setup tab and small rearrange Firmware info on setup tab Mar 12, 2023
@github-actions

This comment has been minimized.

@HThuren
Copy link
Member Author

HThuren commented Mar 12, 2023

@haslinghuis you got your BuildOptions now :-)

@haslinghuis
Copy link
Member

@blckmn check this ☝️

src/js/tabs/setup.js Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@nerdCopter
Copy link
Member

nerdCopter commented Mar 14, 2023

  • i'd personally prefer to see system and firmware information on top, but others may have differing opinion.
  • tested successfully

@HThuren
Copy link
Member Author

HThuren commented Mar 14, 2023

  • i'd personally prefer to see system and firmware information on top, but others may have differing opinion.
  • tested successfully

In fact I tried to move the instrument part to right top , but didn't success...
The idea are maybe more information can come, then the information part will grow.
More info like CPU tempeature, build key, Hardware parts (like what you get from cli:status)

@HThuren
Copy link
Member Author

HThuren commented Mar 14, 2023

Right, now with buildkey and sensors resolved to hardware names.
But I need help to test sensors names, since my hw don't response with hardware numbers, or maybe I have a mistake in the code
(the names in picture are forced to print)

@github-actions

This comment has been minimized.

@nerdCopter
Copy link
Member

yesterday i was typing a suggestion for build-key as well, but ended up not submitting. now i see you coded it 💟 . Might i suggest it link-able to https://build.betaflight.com/api/builds/[build-key]/log and/or https://build.betaflight.com/api/builds/[build-key]/json?

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HThuren
Copy link
Member Author

HThuren commented Mar 15, 2023

@nerdCopter - you got your config and log :-)

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 3662852 into betaflight:master Mar 16, 2023
9 checks passed
@HThuren
Copy link
Member Author

HThuren commented Mar 16, 2023

Great, thank you

@HThuren HThuren deleted the moreInfoOnSetupTab branch March 16, 2023 15:44
@nerdCopter
Copy link
Member

@HThuren , needs css fix or proper class assignment to buttons.

nearly invisible in dark-mode.
image

and seems to be blue (link color) text on light mode.
image

brought to my attention my @ Zzyzx in discord

@HThuren
Copy link
Member Author

HThuren commented Mar 17, 2023

@HThuren , needs css fix or proper class assignment to buttons.

nearly invisible in dark-mode. image

and seems to be blue (link color) text on light mode. image

brought to my attention my @ Zzyzx in discord

Argh, I didn't think of the dark mode, I go to fix.
I also pack the Build options into , maybe just the title to a button, the precentation right now are not nice

@nerdCopter
Copy link
Member

he commented about "no text" listed, so since you're gonna modify', maybe display the id like in your original attempt.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants