Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display average RPM on motor tab #3371

Merged
merged 1 commit into from Mar 13, 2023

Conversation

atomgomba
Copy link
Contributor

@atomgomba atomgomba commented Mar 6, 2023

Display average motor RPM above Master slider if the following conditions are met:

  • DSHOT telemetry is enabled
  • There is no telemetry error
  • All motors are given the same output (i. e. the Master slider is used to change motor output)

I'm using average RPM when setting up dynamic idle RPM, but so far I had to calculate it manually and so I thought it would be useful to let the Configurator do the calculation instead.

2023-03-11_13-34

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Mar 6, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@nerdCopter

This comment was marked as resolved.

@haslinghuis haslinghuis merged commit 6ef0046 into betaflight:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants