Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS icon now reflect fix state #3377

Merged
merged 4 commits into from Mar 13, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Mar 12, 2023

GPS icon change when fixed. Start with Red = GPS configured, but no fix, change to Yellow when fix are reached.

GPS not fixed
image

GPS fixed
image

@github-actions

This comment has been minimized.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 12, 2023
@blckmn
Copy link
Member

blckmn commented Mar 12, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@HThuren
Copy link
Member Author

HThuren commented Mar 12, 2023

@haslinghuis, nice suggestion, code moved to sensor_helpers.js
PR ready from my point of view

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • looks good. i cannot test, however.

@nerdCopter nerdCopter self-requested a review March 13, 2023 19:32
@nerdCopter nerdCopter self-requested a review March 13, 2023 19:33
@haslinghuis haslinghuis merged commit 6cbbaff into betaflight:master Mar 13, 2023
9 checks passed
@nerdCopter
Copy link
Member

nerdCopter commented Mar 13, 2023

i saw this (via email), so i removed my approval
image

but then i mistakenly thought it was already done (when viewing github.com), so re-applied my approval. then it was merged. i think @HThuren wanted to change something before merging.

@haslinghuis
Copy link
Member

All good. Conversation was resolved by @HThuren - we can always make a patch if needed.

@HThuren
Copy link
Member Author

HThuren commented Mar 13, 2023

I was done, nice to have the merge :-)
all good

@HThuren HThuren deleted the gpsIconReflectFix branch March 13, 2023 19:50
@bact2828
Copy link

GPS icon change when fixed. Start with Red = GPS configured, but no fix, change to Yellow when fix are reached.

GPS not fixed image

GPS fixed image

Does the red color indicate that the satellites are being locked?

Did you understand well :)

@HThuren
Copy link
Member Author

HThuren commented Oct 28, 2023

hi @bact2828, the state in use are from FC, ie. FC.GPS_DATA.fix. Same status as in GPS tab:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants