Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: feature ESC_SENSOR #3382

Merged
merged 1 commit into from
Mar 24, 2023
Merged

FIX: feature ESC_SENSOR #3382

merged 1 commit into from
Mar 24, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 18, 2023 •
edited

Fixes: ESC_SENSOR

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 18, 2023
@haslinghuis haslinghuis self-assigned this Mar 18, 2023
@haslinghuis haslinghuis force-pushed the refactor-features branch 2 times, most recently from 205cb3f to a3d7537 Compare March 18, 2023 02:46
@haslinghuis haslinghuis mentioned this pull request Mar 18, 2023
Open
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Refactor features Fix features Mar 18, 2023
@blckmn
Copy link
Member

blckmn commented Mar 18, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • enabled motor_stop, esc_sensor via uart, 3d on fresh flash. (some of the following are defaults, but still show in diff)
# diff

# version
# Betaflight / STM32F7X2 (S7X2) 4.5.0 Mar 18 2023 / 21:08:01 (ef3ee2eb1) MSP API: 1.46

# start the command batch
batch start

board_name TMOTORF7
manufacturer_id TMTR

# feature
feature MOTOR_STOP
feature TELEMETRY
feature 3D
feature LED_STRIP
feature OSD
feature ESC_SENSOR

# serial
serial 2 1024 115200 57600 0 115200

# master
set osd_canvas_width = 30
set osd_canvas_height = 13

profile 0

rateprofile 0

# end the command batch
batch end

@haslinghuis haslinghuis changed the title Fix features FIX: feature ESC_SENSOR Mar 19, 2023
@haslinghuis haslinghuis requested a review from blckmn March 24, 2023 23:11
@haslinghuis haslinghuis merged commit e7b057e into betaflight:master Mar 24, 2023
@haslinghuis haslinghuis deleted the refactor-features branch March 24, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @blckmn @nerdCopter