Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: missing debug modes #3386

Merged
merged 1 commit into from
Mar 21, 2023
Merged

FIX: missing debug modes #3386

merged 1 commit into from
Mar 21, 2023

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 19, 2023
@haslinghuis haslinghuis self-assigned this Mar 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis changed the title Add missing debug modes FIX: missing debug modes Mar 19, 2023
nerdCopter
nerdCopter approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • works.
  • wondering if debugs for angle should be renamed for sorting purposes? e.g. angle_current angle_rate and maybe others e.g. gyro_dual_* (instead of dual_gyro_*)

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Mar 19, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member Author

Yes as having proposed in the firmware PR

@haslinghuis haslinghuis merged commit 35959bb into betaflight:master Mar 21, 2023
@haslinghuis haslinghuis deleted the add-debug branch March 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @blckmn @McGiverGim @nerdCopter