Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align alignDisarmFlagElements #3400

Merged
merged 2 commits into from
Apr 7, 2023
Merged

align alignDisarmFlagElements #3400

merged 2 commits into from
Apr 7, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Apr 4, 2023

Alignment of alignDisarmFlagElements with betaflight runtime_config.h armingDisableFlags_e and a sort of cleanup after #3104

@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 4, 2023
@blckmn
Copy link
Member

blckmn commented Apr 4, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit c20d527 into betaflight:master Apr 7, 2023
@HThuren HThuren deleted the alignDisarmFlagElements branch April 7, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@HThuren HThuren

Labels
RN: REFACTOR
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HThuren @blckmn @limonspb @haslinghuis @nerdCopter