Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more localization on setup tab #3402

Merged
merged 3 commits into from Apr 6, 2023
Merged

Add more localization on setup tab #3402

merged 3 commits into from Apr 6, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Apr 5, 2023

Localization of on setup tab
image

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Apr 5, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

McGiverGim
McGiverGim reviewed Apr 5, 2023
View reviewed changes
src/tabs/setup.html Outdated Show resolved Hide resolved
locales/en/messages.json Outdated Show resolved Hide resolved
@HThuren
Update setup.html
bb09371 
Removed typo
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 5, 2023
haslinghuis
haslinghuis approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change title of the PR

@HThuren HThuren changed the title changed Add more localization of on setup tab Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HThuren HThuren changed the title Add more localization of on setup tab Add more localization on setup tab Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member Author

HThuren commented Apr 6, 2023

@haslinghuis @nerdCopter - thank you

@haslinghuis haslinghuis merged commit 397aba0 into betaflight:master Apr 6, 2023
9 checks passed
@HThuren HThuren deleted the localizeSetupHTML branch April 9, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim left review comments

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HThuren @blckmn @McGiverGim @haslinghuis @nerdCopter