Fix full chip erase

[haslinghuis]

Fixes: #3404

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> PASS
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[nerdCopter]

• verified on two FC's

[howels]

Verified here as well.

[howels]

@haslinghuis flash is still erased if expert mode is disabled

[haslinghuis]

Yes that's by design (only hidden now as requested by @blckmn ) - but has not changed as part of this PR.

It's an expert setting as normally we want to have this enabled to minimize support issues.

[howels]

Yes that's by design (only hidden now as requested by @blckmn ).

It's an expert setting as normally we want to have this enabled to minimize support issues.

Breaks H730 unless expert mode enabled. Why break by default? At least target the config partition specifically and do the wipe cleanly.

[nerdCopter]

H730 needs custom flash address? is this why it breaks?

[haslinghuis]

Also in the documentation for the SPRacing Flight Controllers it's stated to disable full chip erase IIRC.

[blckmn]

disable

We might need to have a disable flash erase option for some targets. Perhaps as part of the populating cloud build options we can include if it's on or off.

[howels]

If the intent is to wipe configuration then the DFU command could target the config partition only for erasure.
However, I cannot see a list of partition layouts for all targets that would enable this easily- which might be why we are simply erasing the entire flash chip.