Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor / range finder information at Setup tab #3410

Merged
merged 3 commits into from Apr 9, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Apr 7, 2023

Use information from firmware 1.46 where MSP_SENSOR_CONFIG now return hardware information regarding sensor / range finder.

shown here, if configured:
image

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Apr 7, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

haslinghuis commented Apr 7, 2023

Can we remove the comma ?

Next request would be to have the target in this overview :)

image

@HThuren
Copy link
Member Author

HThuren commented Apr 7, 2023

Comma easy to fix, but it seems the setup for sonar has disappeared. I have a HCSR04 unit, but need to figure the setup
Found this add sonar to Naze32 FC, more complicated since it use Naze32 motor5 and 6 connector and this Sonar in Betaflight

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member Author

HThuren commented Apr 7, 2023

Sensor was a feature at Configuration tab in betaflight 4.2 ...

@haslinghuis haslinghuis merged commit 56338c2 into betaflight:master Apr 9, 2023
9 checks passed
@HThuren HThuren deleted the addSensorSonar branch April 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants