-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color for vtx ready status #3422
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's cleaner for the translators simply apply the class to the element depending on the content. It's how we it usually in the rest of the code and does not imply new messages with class included.
I am not sure what you address, I used the same setup as GPS fixed, can you give an exampel ?
to embed the class in js or html ? |
This comment has been minimized.
This comment has been minimized.
Sorry for my late response, but I was out. What I was talking about is to do something like this:
More info here: http://api.jquery.com/toggleclass/ This will add/remove the class depending on the second parameter true/false. In this way the messages file is clean, only with basic 'true' and 'false', and we use this in the same part of the code where we decide what to show, and where we assign MSP values to fields. In the CSS file you can have a "red" value for the 'basic' class, and a gree value when the 'basic' class has a 'valid' class too, something similar to (the names are only for reference, better to use something more significative):
Add a "custom" method like your latest version, I think is not the best way, because maybe we want it for YES/NO, or TRUE/FALSE, or ACEPTED/REJECTED, or VALID/NOT VALID... etc. |
@McGiverGim , no worry, I also have a fulltime job :-) Very smart and rigorous way you decribe, I go for it .-. |
hi @McGiverGim Well, I havn't suceed in the requested change, don't you think we still have a 'clean' message file with this construction
called fx |
Could it be something like this: Benky@aeaf2fd ? |
So simple and elegant :-) - thats the way |
Also notice plugging LIPO updates status - but removing LIPO the status remains. But is outside the scope of this PR. |
yes, I'm aware, another PR. :-) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One left :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@McGiverGim should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot more functionality very interesting. The code seems ok to me.
But the less/css code can be a lot better using the less possibilities. Only one difference between the active and the basis class.
I'm on mobile, tomorrow I can suggest the exact code. Sorry but my real work has all my time lately.
No worry and hurry, I look forward to learn about CSS/less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Sorry for my late response, but I think this will work.
This comment has been minimized.
This comment has been minimized.
@HThuren LGTM, only two unresolved issues remaining |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the rest to me is ok. Thanks for the changes.
@HThuren there is a problem. After save it does not retrieve status anymore - going false (red). Please revisit. EDIT: Fixed in |
Change to Device ready has green / red color, are moved up in presentation and are updated if device status change.