Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help text to sections on GPS tab #3485

Merged
merged 2 commits into from Jun 21, 2023
Merged

Add help text to sections on GPS tab #3485

merged 2 commits into from Jun 21, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jun 18, 2023

This PR add help text to sections on GPS tab

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 18, 2023
@HThuren @haslinghuis
Update locales/en/messages.json
980afe0 
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
@blckmn
Copy link
Member

blckmn commented Jun 18, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

Thanks @HThuren. Can we divert our attention to solving existing feature requests aiming to bring down number of issues :)

@haslinghuis haslinghuis merged commit d143d42 into betaflight:master Jun 21, 2023
9 checks passed
@HThuren
Copy link
Member Author

HThuren commented Jun 21, 2023

Thanks @HThuren. Can we divert our attention to solving existing feature requests aiming to bring down number of issues :)

Well, havn't thought on that. Why not :-)

@HThuren HThuren deleted the addHelpToGPSsections branch July 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HThuren @blckmn @haslinghuis @nerdCopter