Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concat longitude and latitude and add location url on Setup tab #3491

Merged
merged 1 commit into from Jul 3, 2023
Merged

Concat longitude and latitude and add location url on Setup tab #3491

merged 1 commit into from Jul 3, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jun 21, 2023 •
edited

This PR concat longitude and latitude and add location url on Setup tab.
Same url as in gps tab
image

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jun 21, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 30, 2023
@blckmn blckmn merged commit 532a672 into betaflight:master Jul 3, 2023
8 checks passed
@HThuren HThuren deleted the urlInPosition branch July 3, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@blckmn blckmn blckmn approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HThuren @blckmn @haslinghuis @sugaarK