Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli reconnect tab #3494

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix cli reconnect tab #3494

merged 1 commit into from
Jun 27, 2023

Conversation

haslinghuis
Copy link
Member

Fixes:

BUG: motors.js:249 Uncaught TypeError: FC.FEATURE_CONFIG.features.isEnabled is not a function

REPRODUCE: from CLI goto Motors TAB.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 25, 2023
@haslinghuis haslinghuis self-assigned this Jun 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jun 25, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 1c06352 into betaflight:master Jun 27, 2023
8 checks passed
@haslinghuis haslinghuis deleted the fix-cli-reconnect-tab branch June 27, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @blckmn @chmelevskij