Fix loading of preset title panel callback

[haslinghuis]

Fixes:

PresetTitlePanel.js:128 Uncaught TypeError: this._onLoadedCallback is not a function
    at PresetTitlePanel._setupHtml (PresetTitlePanel.js:128:31)
    at HTMLDivElement.<anonymous> (PresetTitlePanel.js:58:100)
    at HTMLDivElement.<anonymous> (jquery.min.js:2:85383)
    at Function.each (jquery.min.js:2:3003)
    at S.fn.init.each (jquery.min.js:2:1481)
    at Object.<anonymous> (jquery.min.js:2:85365)
    at c (jquery.min.js:2:28327)
    at Object.fireWith [as resolveWith] (jquery.min.js:2:29072)
    at l (jquery.min.js:2:80045)
    at XMLHttpRequest.<anonymous> (jquery.min.js:2:82499)

@Benky please have a look.

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> FAIL
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[limonspb]

How to reproduce the bug before PR?

[haslinghuis]

Just enter the presets tab and look at console.

[chmelevskij]

Feels that there is extra indirection in this logic. Something like the following is a bit simplified.

Suggested change

	if (this._onLoadedCallback === typeof Function) {
	if (typeof this._onLoadedCallback === 'function') {

[haslinghuis]

Fixed 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!