Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable search in multiple select field for Other Options field when not selected #3500

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jun 27, 2023

Fixes #3457

We should not be able to type here - this part is still there - but disabling also disable the search. Disabling on field exit seems to fix the issue jumping back from typing in Custom Defines to Other Options field.

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 27, 2023
@haslinghuis haslinghuis self-assigned this Jun 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Jun 28, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis changed the title Improve Option field Disable search in multiple select field for Other Options field. Jun 30, 2023
@McGiverGim
Copy link
Member

This disables the search? I use it a lot, each time I need to add some define.
I need to test this, but I like to have a search.

@haslinghuis
Copy link
Member Author

@McGiverGim yes - but I only want to stop enabling typing in the field. Maybe Vue has a better way (as I don't want to extend with adapters).

@nerdCopter
Copy link
Member

i also use the search, then click the filtered result.
maybe better to clear the text after click, but unsure how to clear without clearing selections. ☹️

@haslinghuis
Copy link
Member Author

haslinghuis commented Jul 11, 2023

Agree we should not be able to type in the result, only using search.
Now you have to manually remove the text.

Also often end up typing in the options field when using custom defines field.
As we are heading to Vue components and templates not sure if we should go the route with implementation of adapters etc.

@McGiverGim
Copy link
Member

I don't remove the text. When you search, yes, it remains in the field, but it seems is not "really" there. It seems not to affect the build, only the selected ones.

@haslinghuis haslinghuis changed the title Disable search in multiple select field for Other Options field. Disable search in multiple select field for Other Options field when not selected Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis
Copy link
Member Author

It would be better if we could have a search box separate from the selected items as backspace will remove last selected.

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

nerdCopter commented Aug 17, 2023

It would be better if we could have a search box separate from the selected items as backspace will remove last selected.

i'd be okay with backspace deletion if the cursor could be moved with keyboard. arrow keys do not move cursor :(

edit: seems the whole UI requires mousing only. tabbing between fields is barely functional across the whole UI too. very not computer-centric.
Maybe as @GTorreil suggested. make it similar to blackbox's "Data Included" field 🤷‍♂️ (list items, do not do the 9 of 14 selected shorthand). but really i still like searching.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fa95e911 seems to clear the typing upon field exit; approving.

@haslinghuis haslinghuis merged commit 20c3764 into betaflight:master Aug 24, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-selection branch August 24, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

cloud build feature selection component is buggy
5 participants