Enable video transmitter tab

[haslinghuis]

Fixes #3504

• Fixes backwards compatibility
• Enables virtual vtx feature if vtx build option is present independent of port settings.

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> PASS
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[cruwaller]

Just tested and still no Video Transmitter tab.
There is a warning on Ports tab:

The VTX table has not been set up correctly and without it VTX control will not be possible. Please set up the VTX table in Video Transmitter tab.

quite funny since there are no such a tab :D

Anyway, VTX table is set and works correctly :)

# vtxtable
vtxtable bands 5
vtxtable channels 8
vtxtable band 1 BOSCAM_A A FACTORY    0    0    0    0    0    0    0    0
vtxtable band 2 BOSCAM_B B FACTORY    0    0    0    0    0    0    0    0
vtxtable band 3 BOSCAM_E E FACTORY    0    0    0    0    0    0    0    0
vtxtable band 4 FATSHARK F FACTORY    0 5760    0 5800    0    0    0    0
vtxtable band 5 RACEBAND R FACTORY 5658 5695 5732 5769 5806 5843 5880 5917
vtxtable powerlevels 3
vtxtable powervalues 14 23 0
vtxtable powerlabels 25 200 0

[haslinghuis]

Did you add VTX in Other Options while flashing?

[cruwaller]

Seriously? As mentioned earlier... Quad works and flies, even the VTX control works as expected :)
I test both 4.4 and latest 4.5 Betaflight versions (two different quads)...

Video Transmitter tab is shown and works correctly with 10.9.0 Configurator version... even the VTX settings can be adjusted correctly with BF4.5.

[haslinghuis]

Added new version

[cruwaller]

Just tested the latest version and VTX tab is missing also for SA and Tramp + still no tab for MSP.

[haslinghuis]

Need to fix backwards compatibility as the virtual vtx feature only works with 4.5.0
In 4.5.0 vtx build option + port setting tab enables the virtual vtx feature which decides tab visibility.

[cruwaller]

Now the VTX tab is shown for both 4.5 and 4.4. Thanks a lot!

[haslinghuis]

Thanks for testing 👍

[haslinghuis]

Cleanup. Rebased & squashed

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[freasy]

LGTM

[hydra]

This is still broken for me.

My use case is an ELRS CRSF RX with built-in SPI-connected VTX.

VTX control seems to work as expected after using the cli to configure vtx tables, but the configurator does not show the Video Transmitter tab.

[haslinghuis]

@hydra please check #3512

Sounds like an interesting board

[cruwaller]

I faced this same issue again with the latest nightly build yesterday (on linux). Unfortunately that VTX tab handling seems to be still a bit unstable... USE_VTX is still enabled and cli works.
I will retest with #3512 branch.

[haslinghuis]

@cruwaller removed the logic as more code would be required to support, rather just show the tab and reduce maintenance.