Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent connect failure #3515

Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 17, 2023

Fixing some errors which are intermittent and sometimes hard to produce

  • [serial-backend] callback in reinitializeConnection function had wrong condition.
  • [firmware-flasher] no need for serial disconnect in verifyBoard function if connection is still active. (patience does)
  • [ports] fix callback for writeConfiguration helper function.

Screenshot from 2023-07-17 23-57-53

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 17, 2023
@haslinghuis haslinghuis self-assigned this Jul 17, 2023
@haslinghuis haslinghuis force-pushed the fix-intermittent-connect-failure branch from dd4343d to 0c69452 Compare July 17, 2023 22:31
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jul 18, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@@ -761,7 +761,7 @@ export function reinitializeConnection(callback) {
clearInterval(reconnect);
gui_log(i18n.getMessage('deviceReady'));

if (callback === typeof('function')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested good

@haslinghuis haslinghuis merged commit edd34a1 into betaflight:master Jul 18, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-intermittent-connect-failure branch July 18, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants