Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quad status #3533

Merged
merged 2 commits into from Jul 30, 2023
Merged

Quad status #3533

merged 2 commits into from Jul 30, 2023

Conversation

lipskij
Copy link
Contributor

@lipskij lipskij commented Jul 30, 2023

Added status icons

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 30, 2023
@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing some sonar complaints :)

src/components/quad-status/BottomStatusIcons.vue Outdated Show resolved Hide resolved
src/components/quad-status/BottomStatusIcons.vue Outdated Show resolved Hide resolved
src/components/quad-status/BottomStatusIcons.vue Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jul 30, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 15265b3 into betaflight:master Jul 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@lipskij lipskij

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lipskij @blckmn @chmelevskij @haslinghuis