Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gps_rescue_min_dth #3544

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix gps_rescue_min_dth #3544

merged 1 commit into from
Aug 14, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 13, 2023 •
edited by nerdCopter

Closes #3542
Closes #3546

@haslinghuis haslinghuis added this to the 10.10.0 milestone Aug 13, 2023
@haslinghuis haslinghuis self-assigned this Aug 13, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Aug 13, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim requested changes Aug 14, 2023
View reviewed changes
src/js/tabs/failsafe.js
if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46)) {
$('input[name="gps_rescue_min_dth"]').attr("min", 10);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is cleaner to "join" in some way with the earlier if, because both affect the same paremeter. Maybe a simply else or a binary conditional operator or similar is enough.

@haslinghuis haslinghuis force-pushed the fix-failsafe branch 3 times, most recently from 26f50ef to 980c524 Compare August 14, 2023 10:20
@github-actions

This comment has been minimized.

Sign in to view
McGiverGim
McGiverGim reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is far better but, we are sure about the values? Master seems 10, version 4.4 seems 20, version 4.3 seems 50. We support version 4.3? I suppose that yes. Then this binary must be only for version greater than 4.3, I suppose that 50 is the real value in the HTML code.

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis mentioned this pull request Aug 14, 2023
Closed
@haslinghuis haslinghuis merged commit 5ffd193 into betaflight:master Aug 14, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-failsafe branch August 14, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

UI range for gps_rescue_descent_dist is incorrect in master
4 participants
@haslinghuis @blckmn @McGiverGim @nerdCopter