Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis Logo Update #3559

Merged
merged 4 commits into from Aug 29, 2023
Merged

Axis Logo Update #3559

merged 4 commits into from Aug 29, 2023

Conversation

SupaflyFPV
Copy link
Contributor

Uploaded the svg file for Axis feature on Team Sponsorship banner

@github-actions

This comment has been minimized.

Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SupaflyFPV can you share an screenshot to see how It shows please?

@SupaflyFPV
Copy link
Contributor Author

SupaflyFPV commented Aug 29, 2023

Screenshot 2023-08-29 at 11 21 38

@asizon
Copy link
Member

asizon commented Aug 29, 2023

Screenshot 2023-08-29 at 11 21 38

I mean how It shows on Configurator firmware flasher tab,because sometimes It have unintended changes and we need to fix on css/html side

@SupaflyFPV
Copy link
Contributor Author

Screenshot 2023-08-29 at 11 21 38

I mean how It shows on Configurator firmware flasher tab,because sometimes It have unintended changes and we need to fix on css/html side

I wanted to add the image to the repository, then I thought that someone would assist/advise on setup with the banner...it doesn't show currently...

@asizon
Copy link
Member

asizon commented Aug 29, 2023

Umm, i think that the code IS ready to catch all images from sponsors folder @SupaflyFPV so It should appear

@SupaflyFPV
Copy link
Contributor Author

it didnt show on the version I DL from link above
Screenshot 2023-08-29 at 11 32 37

@blckmn
Copy link
Member

blckmn commented Aug 29, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> PASS

@nerdCopter
Copy link
Member

does it need less margin? i do notice other sponsor images have minimal margin.

image

@SupaflyFPV
Copy link
Contributor Author

ok I cropped and replaced - let me know if its correct

@github-actions

This comment has been minimized.

@nerdCopter
Copy link
Member

nerdCopter commented Aug 29, 2023

  • probably good.

  • wish i could directly test in UI.

  • my image viewer shows this
    image

  • github shows this, but i suspect github render is wrong
    image

  • approving.

@SupaflyFPV
Copy link
Contributor Author

thanks to @KarateBrot for checking the file - now re-uploaded

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Aug 29, 2023

We might like to add a white halo around the lettering. That way in dark mode you will still see it.

Copy link
Member

@KarateBrot KarateBrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready yet. Let's fix some things first

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@haslinghuis haslinghuis merged commit a4e8e2e into betaflight:master Aug 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

6 participants