Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust plot colors #3580

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Adjust plot colors #3580

merged 2 commits into from
Sep 23, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 16, 2023

  • Make colors more readable for light mode when out in the field in motors and sensors tab.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Sep 16, 2023
@haslinghuis haslinghuis self-assigned this Sep 16, 2023
@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Sep 16, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

my eyes are 50+ years old and i find the dark lines harder to see on dark background.

@ctzsnooze
Copy link
Member

Background to this is that I was out in the field and trying to read the debug traces in bright sunlight, and I simply could not read the white-on-pale-green numbers.

I regret to say that I'm a 'day theme' user with white background to the traces, and there a darker trace stands out nicely, and the text is easy to read.

Screen Shot 2023-09-17 at 11 47 40

I accept that in night mode it is now a lot harder to read these traces:

Screen Shot 2023-09-17 at 11 49 26

Looks like the pale colours work best in night mode, but the darker colours are better in day mode.

The numbers are easier to read in both modes, and its the numbers I had most difficulty with.

Maybe... two options:

  • different colours for dark vs light theme (? a lot of work?)
  • show the values with a black background always, and put the colour either behind the 'X' 'Y' or 'Z', or in a little square object of it's own?

Not sure what's best here.

PS looking at those images, it's obvious that at some point it would be super nice if the debug listing showed the name of the debug field... that would be a lot of work though :-)

@github-actions

This comment has been minimized.

@nerdCopter
Copy link
Member

different colours for dark vs light theme [...]

agree.
i see a new commit but i did not test.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nerdCopter
Copy link
Member

👍
image
image

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze
Copy link
Member

Looks great! Thank you @haslinghuis! Together with the Debug names showing up properly, the sensors tab is now much more useful!

@haslinghuis haslinghuis merged commit 7e25ce2 into betaflight:master Sep 23, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-heading branch September 23, 2023 07:56
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
* Adjust plot colors

* Fix dark-theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants