Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing stat desc #3617

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix missing stat desc #3617

merged 1 commit into from
Oct 29, 2023

Conversation

haslinghuis
Copy link
Member

Adding name, text and desc which were omitted in #3615

@haslinghuis haslinghuis added this to the 10.10.0 milestone Oct 28, 2023
@haslinghuis haslinghuis self-assigned this Oct 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Oct 28, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 510ac9f into betaflight:master Oct 29, 2023
8 checks passed
@haslinghuis haslinghuis deleted the fix-missing-stats-3615 branch October 29, 2023 20:09
@HThuren
Copy link
Member

HThuren commented Oct 29, 2023

@haslinghuis
Thank you for this PR, I have spent hours to understand OSD data structure, IO was in fact on track regarding missing names, and then I saw your change, so great.

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix missing stat desc (betaflight#3617)
7dfee7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haslinghuis @blckmn @HThuren @chmelevskij @nerdCopter