Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servo tab: Rearrange mid, min, max and translate Rate: #3623

Merged
merged 1 commit into from Nov 2, 2023
Merged

Servo tab: Rearrange mid, min, max and translate Rate: #3623

merged 1 commit into from Nov 2, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Nov 1, 2023

Rearrange order to align with reciever tab, ie. min, middel, max
image

Translate possible of:
image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Nov 2, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

McGiverGim
McGiverGim approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what is the most expected form for servos, I don't use them, but seems reasonable to me.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 2, 2023
@haslinghuis haslinghuis merged commit af9ec79 into betaflight:master Nov 2, 2023
8 checks passed
@HThuren HThuren deleted the translateServoTab branch November 2, 2023 23:56
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@HThuren @chmelevskij
Servo tab: Rearrange mid, min, max and translate Rate: (betaflight#3623)
b699a44 
Rearrange mid, min, max and translate Rate:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HThuren @blckmn @McGiverGim @haslinghuis