Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sensor status calls #3640

Merged
merged 1 commit into from Nov 24, 2023
Merged

Fix sensor status calls #3640

merged 1 commit into from Nov 24, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 22, 2023 •
edited

Fix calling sensor_status in update_live_status in serial_backend so it is no longer needed to call it from MSP message requests as with gps enabled it got called twice within the same timer loop.

Related to betaflight/betaflight#13177

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 22, 2023
@haslinghuis haslinghuis self-assigned this Nov 22, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Nov 22, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis changed the title Fix Sensor Status calls Fix sensor status calls Nov 22, 2023
asizon
asizon approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haslinghuis haslinghuis merged commit 11279cd into betaflight:master Nov 24, 2023
8 checks passed
@haslinghuis haslinghuis deleted the fix-sensor-status branch November 24, 2023 16:51
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix sensor status calls (betaflight#3640)
3b2ee10 
Fix Sensor Status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asizon asizon asizon approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @blckmn @asizon @nerdCopter