Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readonly field #3662

Merged
merged 1 commit into from Dec 8, 2023
Merged

Fix readonly field #3662

merged 1 commit into from Dec 8, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 7, 2023 •
edited

Adds grey background color to readonly field in motors tab for idleMinRpm

image

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 7, 2023
@haslinghuis haslinghuis self-assigned this Dec 7, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 7, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@ctzsnooze
Copy link
Member

Maybe use same method we use in PID Tuning to set the display characteristics of PID values that are controlled by sliders? They use a consistent way to indicate the 'display-only' state that perhaps we could use here?

@haslinghuis haslinghuis merged commit 7bf176c into betaflight:master Dec 8, 2023
8 checks passed
@haslinghuis haslinghuis deleted the fix-readonly branch December 8, 2023 01:44
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix readonly field (betaflight#3662)
17e7834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @blckmn @ctzsnooze @nerdCopter