New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate map icon instead of view #3668
Rotate map icon instead of view #3668
Conversation
Quality Gate failedFailed conditions 3.6% Duplication on New Code (required ≤ 3%) |
Do you want to test this code? Here you have an automated build: |
@haslinghuis i cannot test for review (i do not have GPS). i see the code is a simple change. |
We need some little adjustments in gps.js. Just found out the formula for degrees to radians was wrong and we send the gpsHeading instead of the imuHeading. I'll raise a PR to adjust that now. |
AUTOMERGE: (FAIL)
|
icon rotates perfectly! Thank you! |
Follow up to #3355. Instead of rotating the map, this PR makes only the icon rotate according to heading.