Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/build output layout #3716

Merged
merged 3 commits into from
Dec 31, 2023
Merged

Fix/build output layout #3716

merged 3 commits into from
Dec 31, 2023

Conversation

chmelevskij
Copy link
Member

  • fix ol.css for nwjs build
  • fix race condition vite global vars

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 31, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 31, 2023
This was referenced Dec 31, 2023
Closed
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 31, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

14.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit c217aad into betaflight:master Dec 31, 2023
7 of 8 checks passed
chmelevskij added a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@chmelevskij
Fix/build output layout (betaflight#3716)
ede5cf4 
* fix: `ol.css` for nwjs build

* fix: global vars broken by race condition

* fix: only copy node modules css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@chmelevskij chmelevskij

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chmelevskij @blckmn @haslinghuis @nerdCopter