Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic offline pwa support #3718

Merged

Conversation

chmelevskij
Copy link
Member

Add basic pwa support for offline use.

offline.mov

Copy link

sonarcloud bot commented Dec 31, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

14.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 31, 2023
@blckmn
Copy link
Member

blckmn commented Dec 31, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

looks good, but i dont know how to build PWA executable for testing.

@chmelevskij
Copy link
Member Author

@nerdCopter yarn dev starts web build, visit http://localhost:8000/ and it should have basic configurator build.

Though, for full offline it needs to be https. So will look into better local setup to actually test offline. For now we'll only be able to fully test this once it's up on https://nightly.app.betaflight.com/ or https://app.betaflight.com/

@nerdCopter
Copy link
Member

@nerdCopter yarn dev starts web build, [...]

okay , i know about yarn dev (same as yarn vite). but it seemed though you launched an "app" in the video.

i ran yan vite fine the other day, so i will approve it.

@haslinghuis haslinghuis merged commit 509811e into betaflight:master Jan 3, 2024
6 of 7 checks passed
@chmelevskij
Copy link
Member Author

@nerdCopter if you visit https://nightly.app.betaflight.com/ in the top right in url bar there is install button.

Screen.Recording.2024-01-10.at.06.34.58.mov

After clicking that you will need to wait for all the request to finish in the network tab

When finished you will get the following popup and that pretty much means it's ready to go

Screenshot 2024-01-10 at 06 50 58

chmelevskij added a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants