Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sponsor background on landing page #3721

Merged
merged 1 commit into from Jan 3, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 1, 2024

image

image

Not sure about Axis image - did some further investigation and both show light or dark mode - but still the axis image is flipped.

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 1, 2024
@haslinghuis haslinghuis self-assigned this Jan 1, 2024
@haslinghuis haslinghuis changed the title Fix sponsor bacground on landing page Fix sponsor background on landing page Jan 1, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@haslinghuis haslinghuis force-pushed the fix-sponsor-background branch 2 times, most recently from ca12ec7 to fe91ff9 Compare January 2, 2024 00:01

This comment has been minimized.

This comment has been minimized.

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@haslinghuis haslinghuis force-pushed the fix-sponsor-background branch 2 times, most recently from 45b06c7 to 32f998a Compare January 2, 2024 01:24
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jan 2, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@ctzsnooze
Copy link
Member

the outcome may depend on the state of the images in btaflight.com? Perhaps we need betaflight/betaflight.com#315 merged before this can be finalised?

@KarateBrot
Copy link
Member

KarateBrot commented Jan 2, 2024

the outcome may depend on the state of the images in btaflight.com? Perhaps we need betaflight/betaflight.com#315 merged before this can be finalised?

No, we have independent file sources in each project.

But it's no issue with the sources. On the flasher tab everything works as intended. The flasher tab displays the logos perfectly. The only display bug is on the front tab. Somehow loadSponsorTile() does not apply the correct color theme to the axis logo but only on the front tab. On the flasher tab it works fine. Do you know what might be the issue @blckmn ?

@nerdCopter
Copy link
Member

for 3e4e9348, i am getting the correct axis logo for light-theme.
image

@blckmn blckmn merged commit f7f8b2b into betaflight:master Jan 3, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-sponsor-background branch January 3, 2024 22:32
@KarateBrot
Copy link
Member

KarateBrot commented Jan 4, 2024

@nerdCopter Works for me now as well

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants