Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More virtual information #3732

Merged
merged 1 commit into from Jan 5, 2024
Merged

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jan 5, 2024

Show more sensors, cpu temp on Setup tab
image
(Sensor will show with #3731)

Show more realistic battery info on Power tab
image

@HThuren HThuren changed the title More virtuel information on setup tab More virtuel information Jan 5, 2024
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jan 5, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@ctzsnooze
Copy link
Member

Is this a bugfix (4.5) or a new feature (4.6) ?

@HThuren
Copy link
Member Author

HThuren commented Jan 5, 2024

Is this a bugfix (4.5) or a new feature (4.6) ?

improvement, see data in some of the new features, suggest 4.5, but 4.6 also fine

@McGiverGim
Copy link
Member

I think this has sense if it goes with the version that has the new values. If we wait one version it will be outdated always.
So to me this must go in the current release.

@nerdCopter
Copy link
Member

nerdCopter commented Jan 5, 2024

supply before/after screenshot please.

@HThuren
Copy link
Member Author

HThuren commented Jan 5, 2024

supply before/after screenshot please.

@nerdCopter here you go

@nerdCopter
Copy link
Member

Is this a bugfix (4.5) or a new feature (4.6) ?

this is nothing except virtual-data for virtual-mode.

@nerdCopter nerdCopter changed the title More virtuel information More virtual information Jan 5, 2024
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haslinghuis haslinghuis merged commit 56ceb48 into betaflight:master Jan 5, 2024
7 checks passed
@HThuren HThuren deleted the virtualFC branch January 5, 2024 22:46
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
More virtuel information on setup tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

6 participants