Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background pattern on full landing tab #3733

Merged
merged 1 commit into from Jan 6, 2024
Merged

Background pattern on full landing tab #3733

merged 1 commit into from Jan 6, 2024

Conversation

TheIsotopes
Copy link
Contributor

This PR will show the background pattern on full landing tab and not only on the content_top

before this PR:

before

after this PR (looks much better):

after

this pr will show the background pattern on full landing tab and not only on the content_top
Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jan 6, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 7f1e0d5 into betaflight:master Jan 6, 2024
7 checks passed
@TheIsotopes TheIsotopes deleted the patch-1 branch January 6, 2024 20:21
@KarateBrot
Copy link
Member

Unfortunately the css styling of the background doesn't work in dark mode anymore. Can you see what's up? Probably the corresponding CSS needs to be changed slightly.

@TheIsotopes
Copy link
Contributor Author

@KarateBrot should fixed in #3734

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
this pr will show the background pattern on full landing tab and not only on the content_top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants