Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved messaging if build request fails #3750

Merged
merged 1 commit into from Jan 13, 2024

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 13, 2024

To test, you can introduce an invalid char into the custom defines.

e.g. TEST$ERROR in custom defines.

@blckmn blckmn added the RN: UI label Jan 13, 2024
@blckmn blckmn added this to the 10.10.0 milestone Jan 13, 2024
@blckmn blckmn self-assigned this Jan 13, 2024
Copy link

sonarcloud bot commented Jan 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

haslinghuis commented Jan 13, 2024

See lot of redefines in failed builds (mostly users adding drivers already in config)

@blckmn
Copy link
Member Author

blckmn commented Jan 13, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

Untitled

@haslinghuis
Copy link
Member

image

Think we should add a link for the log

@nerdCopter
Copy link
Member

i see, i missed the $. so this only reports failed builds, does not necessarily catch bad defines.

@blckmn
Copy link
Member Author

blckmn commented Jan 13, 2024

log

There is no log at this point. It's the case where the build request itself is rejected, eg custom define formatting (invalid chars etc).

@haslinghuis haslinghuis merged commit 370e834 into betaflight:master Jan 13, 2024
6 of 7 checks passed
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

3 participants