Update tooltip for ESC Temp #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Awesome, thx for the effort. |
This comment has been minimized.
This comment has been minimized.
nerdCopter
approved these changes
Jan 16, 2024
McGiverGim
reviewed
Jan 17, 2024
Co-authored-by: Míguel Ángel Mulero Martínez <mcgivergim@gmail.com>
This comment has been minimized.
This comment has been minimized.
ctzsnooze
reviewed
Jan 18, 2024
| @@ -5752,7 +5752,7 @@ | |||
| "description": "One of the elements of the OSD" | |||
| }, | |||
| "osdDescElementEscTemperature": { | |||
| "message": "Temperature reported by ESC telemetry" | |||
| "message": "Temperature reported by ESC telemetry (from one extra wire telemetry or DShot bidirectional telemetry with EDT support enabled. Refer to your ESC firmware for EDT support)" | |||
| }, | |||
There was a problem hiding this comment.
Maybe, "Temperature reported by ESC telemetry, either by serial one wire telemetry, or by DShot bidirectional telemetry with EDT, if supported by your ESC firmware."
|
|
Do you want to test this code? Here you have an automated build: |
McGiverGim
approved these changes
Jan 18, 2024
chmelevskij
pushed a commit
to chmelevskij/betaflight-configurator
that referenced
this pull request
Apr 27, 2024
* Update tooltip for ESC Temp Fixes betaflight/betaflight#13298 * DShot vs Dshot * Update locales/en/messages.json Co-authored-by: Míguel Ángel Mulero Martínez <mcgivergim@gmail.com> * Update messages.json --------- Co-authored-by: Míguel Ángel Mulero Martínez <mcgivergim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes betaflight/betaflight#13298