Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mag declination #3801

Merged
merged 1 commit into from Feb 16, 2024
Merged

Conversation

haslinghuis
Copy link
Member

Fixes: #3761

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 16, 2024
@haslinghuis haslinghuis self-assigned this Feb 16, 2024

This comment has been minimized.

Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member

HThuren commented Feb 16, 2024

There are something with puncation. I can only write and have accepted z.y , but display show z,y (english language choosen)

@haslinghuis
Copy link
Member Author

Shows a point here (using system default = English)

image

@HThuren
Copy link
Member

HThuren commented Feb 16, 2024

yes, I see, my system default are DA = ',', but I think this issue are bigger than this PR. I will approve.

Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See bug described in issue in elder version, and no bug in this PR

@haslinghuis haslinghuis merged commit aeeded6 into betaflight:master Feb 16, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-mag-declination branch February 16, 2024 16:20
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

MAG declination does not save correctly
3 participants