Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset dialog #3803

Merged
merged 1 commit into from Feb 16, 2024
Merged

Fix reset dialog #3803

merged 1 commit into from Feb 16, 2024

Conversation

haslinghuis
Copy link
Member

Fixes #3802

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 16, 2024
@haslinghuis haslinghuis self-assigned this Feb 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@TheIsotopes
Copy link
Contributor

tested and working ... thx

HThuren
HThuren approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
image

@HThuren
Copy link
Member

HThuren commented Feb 16, 2024

Maybe change the prompt text
image

@nerdCopter
Copy link
Member

nerdCopter commented Feb 16, 2024 •
edited

Maybe change the prompt text

edited...

this dialog text was changed rather recently for pilots not understanding that it resets everything. i see your point for button change.

if anything were change again, maybe something similar to Reset to unconfigured defaults (but this is rather long for a button)

@HThuren
Copy link
Member

HThuren commented Feb 16, 2024 •
edited

Then "Remove all settings" ? or "Remove all settings, and restore to default" ?

@haslinghuis
Copy link
Member Author

At this moment we should focus on bugfixes

@haslinghuis haslinghuis merged commit ae9674c into betaflight:master Feb 16, 2024
7 checks passed
@nerdCopter nerdCopter mentioned this pull request Feb 16, 2024
Merged
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix reset dialog (betaflight#3803)
2f1f000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@HThuren HThuren HThuren approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

Confirm Reset dialog wrong format
4 participants
@haslinghuis @TheIsotopes @HThuren @nerdCopter