Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing PID filter slider labels #3811

Merged

Conversation

haslinghuis
Copy link
Member

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 22, 2024
@haslinghuis haslinghuis self-assigned this Feb 22, 2024
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member

HThuren commented Feb 22, 2024

Only issue are the on/off control slider above the troggle, do we move the slider below the toggle ?

@haslinghuis
Copy link
Member Author

This is not a re-design - just adding missing labels.

@haslinghuis haslinghuis merged commit 04e82e0 into betaflight:master Feb 23, 2024
7 checks passed
@haslinghuis haslinghuis deleted the fix-missing-filter-slider-labels branch February 23, 2024 00:15
@TheIsotopes
Copy link
Contributor

TheIsotopes commented Feb 23, 2024

this is only working on dark theme ... pls can you fix this @haslinghuis
enlarge the screenshot and you can see an wrong font color

Screenshot 2024-02-23 094552

@haslinghuis
Copy link
Member Author

@TheIsotopes can you check 3813

@TheIsotopes
Copy link
Contributor

@haslinghuis checked and working 👍

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants