Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing message #3850

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 21, 2024
@haslinghuis haslinghuis self-assigned this Mar 21, 2024
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member

HThuren commented Mar 21, 2024

Are you sure this is a duplicate, the else happen if BuildOptions are empty.
But if this never happen, when navigator.online are true, the construction are not needed.

@nerdCopter nerdCopter self-requested a review March 21, 2024 18:39
@haslinghuis
Copy link
Member Author

Yes this PR is correct - in both cases we get:

image

@haslinghuis haslinghuis changed the title Fix duplicate message Fix missing message Mar 21, 2024
@haslinghuis haslinghuis merged commit 33f8ebe into betaflight:master Mar 21, 2024
7 checks passed
@haslinghuis haslinghuis deleted the fix-duplicate branch March 21, 2024 20:20
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

missing or invalid initialSetupInfoBuildOptionsEmpty
3 participants